Fix issues identified in TSIP on RX72N #8201
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaurav Kumar Singh <[email protected]>
Signed-off-by: Gaurav Kumar Singh <[email protected]>
|
Can one of the admins verify this patch? |
|
Hi @gauravks , Thank you for the PR and email. We will review and I'll coordinate a contributor agreement if needed directly. Thanks, |
dgarske
requested changes
Nov 18, 2024
| @@ -3599,6 +3599,10 @@ static int RsaPrivateDecryptEx(const byte* in, word32 inLen, byte* out, | |||
| ret = wc_CryptoCb_RsaPad(in, inLen, out, | |||
| &outLen, rsa_type, key, rng, &padding); | |||
| if (ret != WC_NO_ERR_TRACE(CRYPTOCB_UNAVAILABLE)) { | |||
| if (ret < 0) { | |||
| break; | |||
There was a problem hiding this comment.
Check indent here. Might be tabs vs. spaces.
| @@ -250,13 +250,13 @@ int wc_tsip_RsaFunction(wc_CryptoInfo* info, TsipUserCtx* tuc) | |||
| return BAD_FUNC_ARG; | |||
| } | |||
| if (ret == 0) { | |||
| info->pk.rsa.outLen = cipher.data_length; | |||
| *(info->pk.rsa.outLen) = cipher.data_length; | |||
There was a problem hiding this comment.
Same. Check indent here. Might be tabs vs. spaces.
miyazakh
requested changes
Nov 19, 2024
| hashData.pdata = (uint8_t*)info->pk.rsa.in; | ||
| hashData.data_length = info->pk.rsa.inLen; | ||
| hashData.pdata = (uint8_t*)info->pk.rsa.out; | ||
| hashData.data_length = info->pk.rsa.outLen; |
There was a problem hiding this comment.
This should be *(info->pk.rsa.outLen) as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix issues in TSIP Decryption and Verification while testing on RX72N
Testing
Tested on Custom RX72N board
Checklist