Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cryptodev debug output #8202

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

LinuxJedi
Copy link
Member

Description

Cryptodev has two sections for the session info struct, cipher and hash. Our debug mode was using hash for the output even if we were using cipher, so would output random data. Simple 'if' statement to do the correct thing.

Testing

Enabling cryptodev and DEBUG_DEVCRYPTO on an STM32MP13 with OpenSTLinux and running wolfcrypt benchmark to check both hash and cipher outputs work.

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

Cryptodev has two sections for the session info struct, cipher and hash.
Our debug mode was using hash for the output even if we were using
cipher, so would output random data. Simple 'if' statement to do the
correct thing.
@dgarske
Copy link
Contributor

dgarske commented Nov 20, 2024

Retest this please:

multi-test:

[check-shell-scripts] [3 of 7] [wolfssl]
    bash -n... done.
    shellcheck scripts...   real 0m3.759s  user 0m3.698s  sys 0m0.028s
    check-shell-scripts OK
/bin/bash: ./config.status: No such file or directory
make: *** [Makefile:5419: config.status] Error 127

@JacobBarthelmeh
Copy link
Contributor

CI failure is:

unrecognized macros used:

HAVE_CRL_UPDATE_CB

Which is resolved in this PR #8182

@JacobBarthelmeh JacobBarthelmeh merged commit be70bea into wolfSSL:master Nov 20, 2024
142 of 143 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants