EdDSA Ed448: sc_muladd now does full reduction #8276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SparkiDev
changed the title
SparkiDev
force-pushed
the
ed448_muladd_full_reduce
branch
from
4c0cf0f to
a695cd3
Compare
sc_muladd was reducing to word boundary and not to order. Now reduces to order as last step.
SparkiDev
force-pushed
the
ed448_muladd_full_reduce
branch
from
a695cd3 to
c9c2833
Compare
douzzer
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
sc_muladd was reducing to word boundary and not to order. Now reduces to order as last step.
Fixes zd#19061
Testing
POC
Checklist