Rename OFFSETOF macro to WolfSSL specific WC_OFFSETOF name #8484
+91
−92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
@jmalak is an approved contributor |
dgarske
previously approved these changes
Feb 21, 2025
douzzer
requested changes
Feb 22, 2025
jmalak
changed the title
jmalak
changed the title
There are the following reasons for this - it conflicts with the OFFSETOF macro in the OS/2 header (Open Watcom) - it is compiler-specific and should use the C standard offsetof definition in the header file stddef.h - it is more transparent unique name
|
ok to test. |
|
retest this please ( |
douzzer
approved these changes
Feb 23, 2025
|
merged through failing workflow "mosquitto Tests" (expired certs at runtime, no possible connection to PR) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are the following reasons for this
offsetofdefinition in the header filestddef.hTesting
How did you test?
Checklist