Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nds build for libnds 2 #8489

Closed
wants to merge 1 commit into from
Closed

Conversation

lesleyrs
Copy link

@lesleyrs lesleyrs commented Feb 22, 2025

Description

libnds got a v2 update recently https://devkitpro.org/viewtopic.php?f=13&t=9662#p18269 and it broke the build due to this: devkitPro/devkitarm-rules@6f96e76

Checklist

  • updated appropriate READMEs

Edit: nvm, even on wii the --enable-opensslextra doesn't seem give me the funcs I want regardless. BN_CTX_new(); is always undefined and not in the wolfssl lib...

@wolfSSL-Bot
Copy link

Can one of the admins verify this patch?

@embhorn
Copy link
Member

embhorn commented Feb 24, 2025

Hi @lesleyrs

Thanks for your interest in wolfSSL. Could you tell us a bit about your project? You mentioned:

Edit: nvm, even on wii the --enable-opensslextra doesn't seem give me the funcs I want regardless. BN_CTX_new(); is always undefined and not in the wolfssl lib...

Did you also try with --enable-opensslall?

@embhorn embhorn self-assigned this Feb 24, 2025
@lesleyrs
Copy link
Author

Hi @lesleyrs

Thanks for your interest in wolfSSL. Could you tell us a bit about your project? You mentioned:

Edit: nvm, even on wii the --enable-opensslextra doesn't seem give me the funcs I want regardless. BN_CTX_new(); is always undefined and not in the wolfssl lib...

Did you also try with --enable-opensslall?

yea that was the issue for wii it turns out, I copied the example command that included --enable-cryptonly which made --enable-opensslextra silently not do what I want but opensslall gave incompatible message. However trying to build without cryptonly fails so I'm assuming it was never fully ported but w/e.

I'm not using wolfssl due to not having access to openssl funcs on nds/wii (nds does build correctly with --enable-opensslextra but gives arm-none-eabi/bin/ld: Error: TLS section too large).

Just made this PR to update NDS build command for other use cases.

Copy link
Member

@embhorn embhorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@embhorn embhorn assigned wolfSSL-Bot and embhorn and unassigned embhorn and wolfSSL-Bot Mar 28, 2025
@embhorn
Copy link
Member

embhorn commented Mar 28, 2025

Hi @lesleyrs

Thanks again for submitting this. We do not typically accept small changes from outside contributors. I can incorporate these changes into a separate PR if you'd like.

Kind regards,
@embhorn - wolfSSL Support

@embhorn embhorn assigned lesleyrs and unassigned embhorn Mar 28, 2025
@lesleyrs
Copy link
Author

sure go ahead, I'll close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants