OCSP openssl compat fixes #8498
Open
+435
−137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check that responderID.ByKey is exactly WC_SHA_DIGEST_SIZE as per RFC 6960. KEYID_SIZE can change across build configuration.
tests blobs contains sha-1 hashes in certificate status
- Added validation for digest type in `wolfSSL_OCSP_cert_to_id` function. - Defined `OCSP_DIGEST` based on available hash types. - Set `hashAlgoOID` in `certId` based on `OCSP_DIGEST`. - Updated `asn.h` to define `OCSP_DIGEST` and `OCSP_DIGEST_SIZE` based on available hash types.
rizlik
force-pushed
the
ocsp_fixes
branch
5 times, most recently
from
ce26fea to
25891dd
Compare
It will be reused in d2i_CERT_ID
|
retest this please ( |
douzzer
requested changes
Feb 26, 2025
There was a problem hiding this comment.
This fixes all the PQ tests I ran, but it breaks with --enable-sm3. I don't see the failures either without --enable-sm3, or on master, just on the combination.
FAILURES:
750: test_wolfSSL_OCSP_id_get0_info
759: test_wolfSSL_OCSP_REQ_CTX
1090: test_ocsp_certid_enc_dec
Repro with --enable-all --enable-sm3 after moving SM3 sources into place from the wolfsm repo (needs wolfcrypt/src/sm3.c, wolfcrypt/src/sm3_asm.S, and wolfssl/wolfcrypt/sm3.h).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description