PKCS Pad: public API to do PKCS padding #8502
Open
+69
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
PKCS padding adds length of padding as repeated padding byte. Use the new function in all places.
|
Retest this please: "Found unhandled org.jenkinsci.plugins.workflow.support.steps.AgentOfflineException exception:" |
dgarske
approved these changes
Feb 25, 2025
dgarske
requested changes
Feb 25, 2025
| } | ||
|
|
||
| return (int)(inSz + padSz); | ||
| return wc_PkcsPad(out, inSz, blockSz); |
There was a problem hiding this comment.
autogen.sh ae5f9b0906... real 0m4.783s user 0m3.338s sys 0m0.490s
configure... real 0m10.600s user 0m5.092s sys 0m6.295s
build...wolfcrypt/src/pkcs7.c: In function ‘wc_PKCS7_PadData’:
wolfcrypt/src/pkcs7.c:8730:12: error: conversion to ‘int’ from ‘word32’ {aka ‘unsigned int’} may change the sign of the result [-Werror=sign-conversion]
8730 | return wc_PkcsPad(out, inSz, blockSz);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[2]: *** [Makefile:8374: wolfcrypt/src/src_libwolfssl_la-pkcs7.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [Makefile:9421: all-recursive] Error 1
make: *** [Makefile:5498: all] Error 2
real 0m3.157s user 0m21.647s sys 0m1.691s
allcryptonly-gcc-c89 fail_build
failed config: '--srcdir' '.' '--disable-jobserver' '--enable-option-checking=fatal' '--enable-c89' '--enable-all' '--disable-all-osp' '--disable-opensslall' '--enable-cryptonly' '--enable-testcert' '--enable-acert' '--disable-examples' '--disable-crypttests' '--disable-benchmark' 'CC=gcc' 'CFLAGS=-std=c89 -pedantic -Wvla -Wdeclaration-after-statement -Wconversion -DWOLF_NO_VARIADIC_MACROS -DXSNPRINTF=snprintf -D_ISOC99_SOURCE=1'
exiting with status 2
results for ae5f9b0906:
failed: allcryptonly-gcc-c89```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PKCS padding adds length of padding as repeated padding byte.
Use the new function in all places.
Fixes zd#19391
Testing
./configure --enable-pkcs7
make test
Checklist