Skip to content

[App size reduction] Optimize login-related, Blaze, and empty store assets #15881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: trunk
Choose a base branch
from

Conversation

iamgabrielma
Copy link
Contributor

@iamgabrielma iamgabrielma commented Jul 8, 2025

Part of WOOMOB-534

Description

In this PR we switch several assets for their optimized versions, so we can reduce the data binaries

Screenshot 2025-07-16 at 15 51 29

Looping in Kiwi as are mostly related to login, blaze, and store selection, with a side quest for taxes:

Testing information

  • Case 1: Log out, and attempt to log in via site credentials. Observe that the views look the same.
Logged out Login via site credentials
Simulator Screenshot - iPad (A16) - Tests - 2025-07-08 at 18 22 14 Simulator Screenshot - iPad (A16) - Tests - 2025-07-08 at 18 25 25
  • Case 2: Blaze intro (not quite sure how to trigger this case, just confirmed in preview)
Before After
Screenshot 2025-07-16 at 15 28 37 Screenshot 2025-07-16 at 15 31 02

Case 3: Woo store selection

I couldn't find the actual case where this is trigger. It should happen during the authentication process, when you're already logged into a WooCommerce store, but you have no WooCommerce stores (?) . It would seem is legacy code from a previous authentication flow but this is no longer possible, so if that's the case we could remove the whole thing rather than just updating the assets, which can be done on a separate PR. In any case, I've confirmed that the assets look the same in /Assets, just couldn't trigger the actual case in-app.

Case 4: Tax rates

  • Go to Orders > Add a product to your order > tap on Set New tax rate. If no tax rates are set up in wp-admin you'll see this screen. If some are already set up please remove them or switch the case just for testing in NewTaxRateSelectorView.viewModel.syncState.empty
No tax rates light No tax rates dark
Simulator Screenshot - iPad mini (A17 Pro) - US store - 2025-07-16 at 15 01 26 Simulator Screenshot - iPad mini (A17 Pro) - US store - 2025-07-16 at 15 02 44

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jul 8, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr15881-f593fff
Version22.8
Bundle IDcom.automattic.alpha.woocommerce
Commitf593fff
Installation URL6mpcvlrehk9ho
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@iamgabrielma iamgabrielma added the type: task An internally driven task. label Jul 16, 2025
@iamgabrielma iamgabrielma added this to the 22.9 milestone Jul 16, 2025
@iamgabrielma iamgabrielma added the type: technical debt Represents or solves tech debt of the project. label Jul 16, 2025
@iamgabrielma iamgabrielma marked this pull request as ready for review July 16, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task An internally driven task. type: technical debt Represents or solves tech debt of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants