Skip to content

[Shortcode-based Checkout] Unblock UI and show a generic error when buyer verification fails. #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

iamdharmesh
Copy link
Collaborator

All Submissions:

  • Does your code follow the WooCommerce Sniffs variant of WordPress coding standards?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Will this change require new documentation or changes to existing documentation?

Changes proposed in this Pull Request:

This PR unblocks the UI and shows a generic error on the Checkout page when the buyer cancels the SCA challenge or buyer verification fails.

Note

We had fixed this issue earlier in PR #265, but it was reintroduced when the verifyBuyer function was removed in PR #342 has reintroduced.

Closes https://linear.app/a8c/issue/SQUARE-132/failing-sca-dialogue-causes-javascript-error

Steps to test the changes in this Pull Request:

  1. Try to place order with card 5248 4800 0021 0026 on shortcode based checkout.
  2. Cancel the verification Challenge once it shows up.
  3. Verify that the Checkout page is unblocked and the page shows a generic error.

Changelog entry

Fix - Unblock UI and show a generic error when buyer verification fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants