refactor: exhaustive deps 문제 해결

woowacourse-teams · Oct 14, 2023 · f29883a · f29883a
1 parent e1f281c
commit f29883a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/frontend/src/components/@common/Toast/index.tsx b/frontend/src/components/@common/Toast/index.tsx
@@ -39,7 +39,7 @@ const Toast = (props: ToastItem) => {
     setTimeout(() => {
       setToastList((prev) => prev.filter(({ id: toastId }) => toastId !== id));
     }, 200);
-  }, []);
+  }, [id, setToastList]);
 
   const handleClickButton = () => {
     onClickButton?.();

diff --git a/frontend/src/hooks/@common/useIntersectionRef.ts b/frontend/src/hooks/@common/useIntersectionRef.ts
@@ -2,11 +2,14 @@ import { useCallback, useMemo } from 'react';
 import createObserver from 'utils/createObserver';
 
 const useIntersectionRef = (onIntersecting: () => void) => {
-  const observer = useMemo(() => createObserver(onIntersecting), []);
+  const observer = useMemo(() => createObserver(onIntersecting), [onIntersecting]);
 
-  const intersectionRef = useCallback(<T extends Element>(instance: T | null) => {
-    if (instance) observer.observe(instance);
-  }, []);
+  const intersectionRef = useCallback(
+    <T extends Element>(instance: T | null) => {
+      if (instance) observer.observe(instance);
+    },
+    [observer]
+  );
 
   return intersectionRef;
 };