Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FE] index.html og image를 우리 s3에서 가져오도록 변경 #998

Merged
merged 1 commit into from
Feb 10, 2025
Merged

[FE] index.html og image를 우리 s3에서 가져오도록 변경 #998

merged 1 commit into from
Feb 10, 2025

Conversation

jinhokim98
Copy link
Contributor

issue

구현 사항

index.html 내 og image를 우리 s3에서 가져오는 방식으로 변경

크루위키 s3에 연결되어있던 이미지를 우리 s3에서 가져오는 것으로 변경했습니다.

<meta property="og:image" content="<%= process.env.IMAGE_URL %>/og-image.jpg" />

🫡 참고사항

@github-actions github-actions bot requested review from pakxe, soi-ha and Todari February 5, 2025 09:28
@jinhokim98 jinhokim98 added 🖥️ FE Frontend 🚧 refactor refactoring labels Feb 5, 2025
@jinhokim98 jinhokim98 added this to the v3.2.1 milestone Feb 5, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2025

🚀 storybook: https://66a9dea5db27afc2b8f91ba7-wvwqqvflsv.chromatic.com/

soi-ha
soi-ha approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@soi-ha soi-ha left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

앜ㅋㅋㅋㅋㅋ 이거 완전 까먹고 있던 건데ㅋㅋㅋㅋㅋ 바꿔줘서 고맙습니당 쿠키

그동안 맛있게 잘 먹었다 크루위키.

Todari
Todari approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@Todari Todari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀🚀🚀🚀🚀

@jinhokim98 jinhokim98 merged commit 58e224d into fe-dev Feb 10, 2025
3 checks passed
@jinhokim98 jinhokim98 deleted the feature/#997 branch February 10, 2025 05:58
@soi-ha soi-ha mentioned this pull request Feb 10, 2025
Merged
soi-ha pushed a commit that referenced this pull request Feb 10, 2025
@jinhokim98 @soi-ha
refactor: og-image 우리 s3를 이용하는 방식으로 변경 (#998)
4a8d23b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soi-ha soi-ha soi-ha approved these changes

@Todari Todari Todari approved these changes

@pakxe pakxe Awaiting requested review from pakxe

Assignees

@jinhokim98 jinhokim98

Labels
🖥️ FE Frontend 🚧 refactor refactoring
Projects
2024-haeng-dong
Status: ✅ Done
Milestone
v3.2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@jinhokim98 @soi-ha @Todari