-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(member): change to only allow members 14 years of age or older to sign up #755
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
흥미롭게 읽었습니다 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
리뷰가 많이 늦었네요 🙇♀️
기능도 잘 동작하고 코드도 깔끔하게 작성되어 있어 별다른 코멘트를 남기지 않았습니다.
고생하셨습니다!
age > TEENAGER_AGE || | ||
(age === TEENAGER_AGE && (monthDifference > 0 || (monthDifference === 0 && dayDifference >= 0))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
잡담: 서버 검증에 비해 복잡하군요 ㅋㅋ
service-apply/src/main/kotlin/apply/domain/member/MinimumAgeRequirement.kt
Lines 11 to 12 in f025dc9
val age = Period.between(information.birthday, baseDate).years | |
require(age >= this.age) { "만 ${this.age}세 미만은 회원 가입할 수 없습니다." } |
Resolves #742
해결하려는 문제가 무엇인가요?
어떻게 해결했나요?
어떤 부분에 집중하여 리뷰해야 할까요?
참고 자료
RCA 룰
r: 꼭 반영해 주세요. 적극적으로 고려해 주세요. (Request changes)
c: 웬만하면 반영해 주세요. (Comment)
a: 반영해도 좋고 넘어가도 좋습니다. 그냥 사소한 의견입니다. (Approve)