Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(member): change to only allow members 14 years of age or older to sign up #755

Merged
merged 7 commits into from
Jul 9, 2024

Conversation

woowahan-pjs
Copy link
Contributor

Resolves #742

해결하려는 문제가 무엇인가요?

  • 개인정보 보호법에 따라 만 14세 미만 아동의 가입을 금지하고자 합니다.

어떻게 해결했나요?

  • 클라이언트에서 서버에 이르기까지 모든 곳에 만 나이 유효성 검사 로직을 넣었습니다.

어떤 부분에 집중하여 리뷰해야 할까요?

  • 최소 가입 연령, 최대 가입 연령 등 다양한 가입 조건을 충족할 수 있도록 모델링하고 구현하였습니다.

참고 자료


RCA 룰

r: 꼭 반영해 주세요. 적극적으로 고려해 주세요. (Request changes)
c: 웬만하면 반영해 주세요. (Comment)
a: 반영해도 좋고 넘어가도 좋습니다. 그냥 사소한 의견입니다. (Approve)

Copy link

@woowahan-neo woowahan-neo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~

Copy link

@woowahan-leah woowahan-leah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

흥미롭게 읽었습니다 👍

Copy link

@woowabrie woowabrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰가 많이 늦었네요 🙇‍♀️
기능도 잘 동작하고 코드도 깔끔하게 작성되어 있어 별다른 코멘트를 남기지 않았습니다.
고생하셨습니다!

Comment on lines +12 to +13
age > TEENAGER_AGE ||
(age === TEENAGER_AGE && (monthDifference > 0 || (monthDifference === 0 && dayDifference >= 0)))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

잡담: 서버 검증에 비해 복잡하군요 ㅋㅋ

val age = Period.between(information.birthday, baseDate).years
require(age >= this.age) { "${this.age}세 미만은 회원 가입할 수 없습니다." }

@woowahan-pjs woowahan-pjs merged commit 757d8c6 into develop Jul 9, 2024
@woowahan-pjs woowahan-pjs deleted the feature/birthday branch July 9, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants