-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mission): add the submission start date time #765
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨슴다~ 따봉 👍
@@ -42,6 +49,9 @@ class Mission( | |||
@Column(nullable = false) | |||
private var deleted: Boolean = false | |||
|
|||
val submittable: Boolean | |||
get() = now().isBetween(submitPeriod) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get() = now().isBetween(submitPeriod) | |
get() = submitPeriod.contains(now()) | |
// 이름이 애매하다면..? submitPeriod.isWithin(now()) |
c: MissionSubmitPeriod
내에 확장함수 없애고 위와 같이 작성하는 것이 더 자연스러워 보이는데 어떻게 생각하시나요?
d766594
to
bb9c624
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다!
frontend
에서 특별히 리뷰해야 할 만한 부분은 없었어요.
Resolves #768
해결하려는 문제가 무엇인가요?
어떻게 해결했나요?
PREPARED
및IN_PROGRESS
를 추가하였습니다.SUBMITTABLE
을 제거하였습니다.어떤 부분에 집중하여 리뷰해야 할까요?
submittable
을 제거하였습니다.참고 자료
RCA 룰
r: 꼭 반영해 주세요. 적극적으로 고려해 주세요. (Request changes)
c: 웬만하면 반영해 주세요. (Comment)
a: 반영해도 좋고 넘어가도 좋습니다. 그냥 사소한 의견입니다. (Approve)