[Dependency Analysis] Remove Unused Dependencies [January 2025]
#1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This dependency is completely unused. FYI: It got introduced as part of this (7d8d37c) commit, a part of implementing placeholders in compose. ------------------------------------------------------------------------ This removal was suggested by the dependency analysis report, see below: Advice for :media-placeholders Unused dependencies which should be removed: ... implementation 'androidx.compose.material3:material3:1.3.1' ...
This dependency is completely unused. FYI: It got introduced as part of this (7d8d37c) commit, a part of implementing placeholders in compose. ------------------------------------------------------------------------ This removal was suggested by the dependency analysis report, see below: Advice for :media-placeholders Unused dependencies which should be removed: ... implementation 'androidx.compose.ui:ui-tooling-preview:1.7.5'
Although removing the 'androidx.compose.ui:ui' is enough by itself and the build is okay, it is better to add 'androidx.compose.ui:ui-unit' for transitive dependency related purposes. FYI: It got introduced as part of this (7d8d37c) commit, a part of implementing placeholders in compose. ------------------------------------------------------------------------ This addition was suggested by the dependency analysis report, see below: These transitive dependencies should be declared directly: ... implementation 'androidx.compose.ui:ui-unit:1.7.5' ...
Removing the 'androidx.compose.foundation:foundation' dependency wasn't enough by itself as the build was then failing. Adding the transient 'androidx.compose.foundation:foundation-layout' dependency was actually required in order to make the build successful again. FYI: It got introduced as part of this (7d8d37c) commit, a part of implementing placeholders in compose. ------------------------------------------------------------------------ This replacement was suggested by the dependency analysis report, see below: Unused dependencies which should be removed: implementation 'androidx.compose.foundation:foundation:1.7.5' ... These transitive dependencies should be declared directly: ... implementation 'androidx.compose.foundation:foundation-layout:1.7.5' ...
|
👋 @planarvoid @danilo04 a friendly reminder about this. 🙏 |
|
👋 @planarvoid @danilo04 another friendly reminder about this. 🙏 |
|
Awesome, thank you so much @danilo04 for helping with reviewing, but also merging this! 🙇 ❤️ 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on the
unusedrelated advises generated by the Dependency Analysis Gradle plugin (see p1738189833942969-slack-C0787KRDYDC), this PR removes the newly added but unused dependencies from this project.Reviewers
👋 @planarvoid & @danilo04, just and FYI here, that I added both of your as reviewers to this change because it relates to this #1095 PR you both worked on. 🙏
Testing Steps
./gradlew buildHealthtask and verify that there is nounusedrelated advise remaining within both reports, JSON and txt included:build-health-report.json-> Search forunusedCountbuild-health-report.txt-> Search forunusedunusedrelated advise remaining within both reports, JSON and txt included:build-health-report.json-> Search forunusedCountbuild-health-report.txt-> Search forunused