sync with main Recruitee/mix_docker #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given the args are passed down to docker build and that Docker emits an error on a arg it does not know, we need to filter out our own args to keep Docker happy.
Allow docker image version to be customized
Support umbrella apps with default distillery config
You can customize the length of the short version of the git sha by suffixing a length.
Example: {git_sha7}
Defaults to a sha of 10 characters.
Closes #23
Erlang 19.3 is pretty nice because it adds support for SIGTERM in Beam.
Update to Erlang 19.3
Custom length {git_sha}
Can run with custom Mix.env, not just prod.
change recomended version in README
This reverts commit 8d05205.
Add depreciation notice do README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.