fix(draw): memorize line text property #WIK-15737 (#920)

worktile · Jun 26, 2024 · 4bd014d · 4bd014d
1 parent 2d8b964
commit 4bd014d
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 5 deletions.
diff --git a/.changeset/giant-pears-matter.md b/.changeset/giant-pears-matter.md
@@ -0,0 +1,5 @@
+---
+'@plait/draw': patch
+---
+
+memorize line text property
diff --git a/packages/draw/src/line.component.ts b/packages/draw/src/line.component.ts
@@ -1,4 +1,4 @@
-import { PlaitBoard, PlaitPluginElementContext, OnContextChanged, getElementById, createDebugGenerator } from '@plait/core';
+import { PlaitBoard, PlaitPluginElementContext, OnContextChanged, getElementById, createDebugGenerator, PlaitNode } from '@plait/core';
 import { LineText, PlaitGeometry, PlaitLine } from './interfaces';
 import { LineShapeGenerator } from './generators/line.generator';
 import { LineActiveGenerator } from './generators/line-active.generator';
@@ -127,7 +127,9 @@ export class LineComponent extends CommonElementFlavour<PlaitLine, PlaitBoard> i
                 return getLineTextRectangle(this.board, this.element, index);
             },
             onChange: (textManageChangeData: TextManageChangeData) => {
-                const texts = [...this.element.texts];
+                const path = PlaitBoard.findPath(this.board, this.element);
+                const node = PlaitNode.get(this.board, path) as PlaitLine;
+                const texts = [...node.texts];
                 const newWidth = textManageChangeData.width < MIN_TEXT_WIDTH ? MIN_TEXT_WIDTH : textManageChangeData.width;
                 texts.splice(index, 1, {
                     text: textManageChangeData.newText ? textManageChangeData.newText : this.element.texts[index].text,

diff --git a/packages/draw/src/plugins/with-line-text.ts b/packages/draw/src/plugins/with-line-text.ts
@@ -9,7 +9,7 @@ import {
 } from '@plait/core';
 import { PlaitDrawElement, PlaitLine } from '../interfaces';
 import { Node } from 'slate';
-import { buildText, getRatioByPoint, getTextManages } from '@plait/common';
+import { buildText, getMemorizedLatest, getRatioByPoint, getTextManages } from '@plait/common';
 import { DrawTransforms } from '../transforms';
 import { getLinePoints } from '../utils/line/line-basic';
 import { getHitLineTextIndex } from '../utils/position/line';
@@ -36,8 +36,9 @@ export const withLineText = (board: PlaitBoard) => {
                     editHandle(board, hitTarget, textIndex);
                 } else {
                     const ratio = getRatioByPoint(points, point);
+                    const textMemory = getMemorizedLatest('line')?.text || {};
                     texts.push({
-                        text: buildText(LINE_TEXT),
+                        text: buildText(LINE_TEXT, undefined, textMemory),
                         position: ratio,
                         width: 28,
                         height: 20

diff --git a/packages/draw/src/utils/memorize.ts b/packages/draw/src/utils/memorize.ts
@@ -35,7 +35,6 @@ export const getMemorizeKey = (element: PlaitElement) => {
 
 export const getLineMemorizedLatest = () => {
     const properties = getMemorizedLatest(MemorizeKey.line);
-    delete properties?.text;
     return { ...properties } || {};
 };