fix(common): do not handle the hierarchy of the group element when ad…

…dGroup #WIK-15137 (#829)
worktile · Apr 16, 2024 · 99fecff · 99fecff
1 parent 8459129
commit 99fecff
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/.changeset/breezy-waves-share.md b/.changeset/breezy-waves-share.md
@@ -0,0 +1,5 @@
+---
+'@plait/core': patch
+---
+
+do not handle the hierarchy of the group element when addGroup
diff --git a/packages/core/src/transforms/group.ts b/packages/core/src/transforms/group.ts
@@ -26,13 +26,12 @@ export const addGroup = (board: PlaitBoard, elements?: PlaitElement[]) => {
             NodeTransforms.setNode(board, { groupId: group.id }, path);
         });
         const selectedElements = getSelectedElements(board);
-        const highestIndexOfSelectedElement = getHighestIndexOfElement(board, [...selectedElements, ...selectedGroups]);
+        const highestIndexOfSelectedElement = getHighestIndexOfElement(board, selectedElements);
         const indices = getElementsIndices(board, highestSelectedElements);
         const isContinuous = isIndicesContinuous(indices);
         if (!isContinuous) {
-            moveElementsToNewPathAfterAddGroup(board, [...selectedElements, ...selectedGroups], [highestIndexOfSelectedElement - 1]);
+            moveElementsToNewPathAfterAddGroup(board, selectedElements, [highestIndexOfSelectedElement - 1]);
         }
-        const groupPath = [highestIndexOfSelectedElement + 1];
         if (hasSelectedElementsInSameGroup(highestSelectedElements)) {
             const newGroupId = selectedIsolatedElements[0].groupId;
             NodeTransforms.insertNode(
@@ -41,10 +40,10 @@ export const addGroup = (board: PlaitBoard, elements?: PlaitElement[]) => {
                     ...group,
                     groupId: newGroupId
                 },
-                groupPath
+                [board.children.length]
             );
         } else {
-            NodeTransforms.insertNode(board, group, groupPath);
+            NodeTransforms.insertNode(board, group, [board.children.length]);
         }
     }
 };