fix(mind): fix defects in dblclick and moving #WIK-16158 (#959)

worktile · Jul 29, 2024 · a47f09a · a47f09a
1 parent 6155196
commit a47f09a
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/.changeset/nine-rockets-fetch.md b/.changeset/nine-rockets-fetch.md
@@ -0,0 +1,6 @@
+---
+'@plait/draw': patch
+'@plait/mind': patch
+---
+
+fix defects in dblclick and moving
diff --git a/packages/draw/src/plugins/with-arrow-line-text.ts b/packages/draw/src/plugins/with-arrow-line-text.ts
@@ -22,11 +22,9 @@ export const withArrowLineText = (board: PlaitBoard) => {
     board.dblClick = (event: MouseEvent) => {
         if (!PlaitBoard.isReadonly(board)) {
             const clickPoint = toViewBoxPoint(board, toHostPoint(board, event.x, event.y));
-            const hitTarget = getHitElementByPoint(board, clickPoint, (element: PlaitElement) => {
-                return PlaitDrawElement.isArrowLine(element);
-            }) as undefined | PlaitArrowLine;
-            const hitTargetPath = hitTarget && PlaitBoard.findPath(board, hitTarget);
-            if (hitTarget) {
+            const hitTarget = getHitElementByPoint(board, clickPoint) as undefined | PlaitArrowLine;
+            if (hitTarget && PlaitDrawElement.isArrowLine(hitTarget)) {
+                const hitTargetPath = hitTarget && PlaitBoard.findPath(board, hitTarget);
                 const points = getArrowLinePoints(board, hitTarget);
                 const point = getNearestPointBetweenPointAndSegments(clickPoint, points);
                 const texts = hitTarget.texts?.length ? [...hitTarget.texts] : [];

diff --git a/packages/mind/src/plugins/with-node-dnd.ts b/packages/mind/src/plugins/with-node-dnd.ts
@@ -119,6 +119,7 @@ export const withNodeDnd = (board: PlaitBoard) => {
             });
 
             PlaitBoard.getHost(board).appendChild(dragFakeNodeG);
+            return;
         }
 
         pointerMove(event);
-Original file line number
+Diff line change
@@ Expand Up / @@ -119,6 +119,7 @@ export const withNodeDnd = (board: PlaitBoard) => { @@
                 });
                 PlaitBoard.getHost(board).appendChild(dragFakeNodeG);
+                return;
             }
             pointerMove(event);
@@ Expand Down @@