fix(text-plugins): prevent getMarks when editor children is empty

worktile · Jun 21, 2024 · fcd0af8 · fcd0af8
1 parent ad0ea0c
commit fcd0af8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/.changeset/silver-planets-exercise.md b/.changeset/silver-planets-exercise.md
@@ -0,0 +1,5 @@
+---
+'@plait/text-plugins': patch
+---
+
+prevent getMarks when editor children is empty
diff --git a/packages/text-plugins/src/utils/marks.ts b/packages/text-plugins/src/utils/marks.ts
@@ -1,19 +1,13 @@
 import { CustomText, getTextEditorsByElement, getTextManages } from '@plait/common';
 import { PlaitElement } from '@plait/core';
 import { PlaitMarkEditor } from '../mark/mark.editor';
-import { Element } from 'slate';
 
 export const getTextMarksByElement = (element: PlaitElement) => {
     const editors = getTextEditorsByElement(element);
     const editor = editors[0];
-    if (!editor) {
+    if (!editor || editor.children.length === 0) {
         return {};
     }
-    if (editor.children.length === 0) {
-        const textManage = getTextManages(element)[0];
-        const currentMarks: Omit<CustomText, 'text'> = PlaitMarkEditor.getMarksByElement(editor.children[0] as Element);
-        return currentMarks;
-    }
     const currentMarks: Omit<CustomText, 'text'> = PlaitMarkEditor.getMarks(editor);
     return currentMarks;
 };