Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(draw): support vector pen #WIK-15919 #943

Merged
merged 11 commits into from
Jul 15, 2024
Merged

feat(draw): support vector pen #WIK-15919 #943

merged 11 commits into from
Jul 15, 2024

Conversation

MissLixf
Copy link
Collaborator

@MissLixf MissLixf commented Jul 4, 2024

No description provided.

@vercel Vercel
Copy link

vercel bot commented Jul 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plait ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 12, 2024 7:43am
plait-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 12, 2024 7:43am

pubuzhixing8
pubuzhixing8 reviewed Jul 5, 2024
View reviewed changes
packages/draw/src/interfaces/arrow-line.ts Outdated Show resolved Hide resolved
packages/draw/src/generators/line.generator.ts Outdated Show resolved Hide resolved
packages/draw/src/line.component.ts Outdated Show resolved Hide resolved
packages/draw/src/plugins/with-draw-fragment.ts Show resolved Hide resolved
packages/draw/src/plugins/with-vector-line-resize.ts Show resolved Hide resolved
packages/draw/src/plugins/with-vector-pen.ts Outdated Show resolved Hide resolved
packages/draw/src/utils/hit.ts Show resolved Hide resolved
packages/draw/src/utils/vector-line.ts Show resolved Hide resolved
packages/draw/src/utils/vector-line.ts Outdated Show resolved Hide resolved
pubuzhixing8
pubuzhixing8 reviewed Jul 5, 2024
View reviewed changes
packages/angular-board/src/board/board.component.ts Outdated
filter(
() =>
(this.isFocused && !PlaitBoard.hasBeenTextEditing(this.board)) ||
PlaitBoard.isPointer(this.board, VectorPenPointerType.vectorPen)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个条件有意义吗？

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有，否则在VectorPen里不相应双击事件

packages/draw/src/plugins/with-vector-pen-create.ts Show resolved Hide resolved
packages/draw/src/utils/vector-line.ts Show resolved Hide resolved
packages/draw/src/vector-line.component.ts Outdated Show resolved Hide resolved
packages/draw/src/plugins/with-vector-pen-create.ts Outdated Show resolved Hide resolved
packages/draw/src/plugins/with-vector-pen-create.ts Outdated Show resolved Hide resolved
@pubuzhixing8 pubuzhixing8 merged commit d66c77e into develop Jul 15, 2024
4 checks passed
@pubuzhixing8 pubuzhixing8 deleted the #WIK-15919 branch July 15, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pubuzhixing8 pubuzhixing8 pubuzhixing8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MissLixf @pubuzhixing8