refactor: remove fancybox outelement span

worktile · Sep 29, 2019 · 41966e3 · 41966e3
1 parent 51b6c4f
commit 41966e3
Show file tree

Hide file tree

Showing 10 changed files with 23 additions and 26 deletions.
diff --git a/dist/quill.bubble.css b/dist/quill.bubble.css
@@ -1,5 +1,5 @@
 /*!
- * Quill Editor v2.0.12
+ * Quill Editor v2.0.14
  * https://quilljs.com/
  * Copyright (c) 2014, Jason Chen
  * Copyright (c) 2013, salesforce.com

diff --git a/dist/quill.core.css b/dist/quill.core.css
@@ -1,5 +1,5 @@
 /*!
- * Quill Editor v2.0.12
+ * Quill Editor v2.0.14
  * https://quilljs.com/
  * Copyright (c) 2014, Jason Chen
  * Copyright (c) 2013, salesforce.com

diff --git a/dist/quill.core.js b/dist/quill.core.js
diff --git a/dist/quill.js b/dist/quill.js
diff --git a/dist/quill.min.js b/dist/quill.min.js
diff --git a/dist/quill.min.js.map b/dist/quill.min.js.map
diff --git a/dist/quill.snow.css b/dist/quill.snow.css
@@ -1,5 +1,5 @@
 /*!
- * Quill Editor v2.0.12
+ * Quill Editor v2.0.14
  * https://quilljs.com/
  * Copyright (c) 2014, Jason Chen
  * Copyright (c) 2013, salesforce.com

diff --git a/dist/unit.js b/dist/unit.js
diff --git a/formats/image.js b/formats/image.js
@@ -6,24 +6,20 @@ const ATTRIBUTES = ['alt', 'height', 'width'];
 class Image extends EmbedBlot {
   static create(value) {
     const node = super.create(value);
-    const span = document.createElement('span');
     if (typeof value === 'string') {
       node.setAttribute('src', this.sanitize(value));
-      span.setAttribute('href', this.sanitize(value));
-      span.setAttribute('data-fancybox-href', this.sanitize(value));
+      node.setAttribute('data-fancybox-href', this.sanitize(value));
     }
     if (value.thumbUrl) {
       node.setAttribute('src', this.sanitize(value.thumbUrl));
     }
     if (value.originUrl) {
-      span.setAttribute('href', this.sanitize(value.originUrl));
-      span.setAttribute('data-fancybox-href', this.sanitize(value.originUrl));
+      node.setAttribute('data-fancybox-href', this.sanitize(value.originUrl));
     }
-    span.setAttribute('data-fancybox-type', 'image');
-    span.setAttribute('data-fancybox-group', 'editor');
-    span.classList.add('fancybox');
-    span.appendChild(node);
-    return span;
+    node.setAttribute('data-fancybox-type', 'image');
+    node.setAttribute('data-fancybox-group', 'editor');
+    node.classList.add('fancybox');
+    return node;
   }
 
   static formats(domNode) {

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "quill",
-  "version": "2.0.12",
+  "version": "2.0.14",
   "description": "Your powerful, rich text editor",
   "author": "Jason Chen <[email protected]>",
   "homepage": "http://quilljs.com",
@@ -155,7 +155,8 @@
     "test:functional": "./_develop/scripts/puppeteer.sh",
     "test:unit": "npm run build; karma start _develop/karma.config.js",
     "test:coverage": "webpack --env.coverage --config _develop/webpack.config.js; karma start _develop/karma.config.js --reporters coverage",
-    "travis": "npm run lint && karma start _develop/karma.config.js --reporters dots,saucelabs"
+    "travis": "npm run lint && karma start _develop/karma.config.js --reporters dots,saucelabs",
+    "copy-to-editor": "npm run build && cp \"./dist/quill.js\" ../ngx-tethys-editor/node_modules/quill/dist"
   },
   "keywords": [
     "editor",