Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Processor Error types #21

Merged
merged 5 commits into from
Mar 12, 2025
Merged

Processor Error types #21

merged 5 commits into from
Mar 12, 2025

Conversation

reneca
Copy link
Contributor

@reneca reneca commented Feb 11, 2025

Error type for processors are not handle #17 .
The goal is to do a correct error handling for processors/adaptors.

@reneca reneca added the enhancement New feature or request label Feb 11, 2025
@reneca reneca requested review from Timmy80 and oschijns February 11, 2025 16:10
@reneca reneca self-assigned this Feb 11, 2025
@reneca reneca marked this pull request as draft February 11, 2025 16:10
Copy link
Collaborator

@oschijns oschijns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not many issues.

@reneca reneca requested a review from oschijns February 26, 2025 14:36
oschijns
oschijns previously approved these changes Feb 26, 2025
Copy link
Collaborator

@oschijns oschijns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me

Timmy80
Timmy80 previously approved these changes Mar 7, 2025
Copy link
Contributor

@Timmy80 Timmy80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found some missing négations in doc strings. can be merged as is, and fix doc later?

Olivier SCHYNS and others added 4 commits March 9, 2025 14:51
@reneca reneca dismissed stale reviews from Timmy80 and oschijns via bdbf36c March 9, 2025 14:06
@reneca
Copy link
Contributor Author

reneca commented Mar 9, 2025

Fixed all code findings. But an issue appear with protobuf in deny. Need to be corrected here

@reneca reneca marked this pull request as ready for review March 12, 2025 12:41
@reneca reneca merged commit d66573d into main Mar 12, 2025
6 checks passed
@reneca reneca deleted the error_types branch March 12, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants