added check for consul tag #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elvizlai
requested changes
May 12, 2017
| @@ -73,7 +96,7 @@ func (cw *ConsulWatcher) Next() ([]*naming.Update, error) { | |||
| // queryConsul is helper function to query consul | |||
| func (cw *ConsulWatcher) queryConsul(q *consul.QueryOptions) ([]string, uint64, error) { | |||
| // query consul | |||
| cs, meta, err := cw.cc.Health().Service(cw.cr.ServiceName, "", true, q) | |||
| cs, meta, err := cw.cc.Health().Service(cw.name(), cw.tag(), true, q) | |||
There was a problem hiding this comment.
If service is v1.hello_sever
It registered in consul as v1. hello_sever-ip-port
Your changes break the law. The service you found now becoming hello_sever not v1. hello_sever
It looks like you forgot to handle the consul Register.
https://github.com/wothing/wonaming/blob/master/consul/register.go#L22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I've added code to check for the tag of a service in consul.