Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD METHOD isRewardedVideoPlacementCapped #61

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

ItagibaALIX
Copy link

No description provided.

@Kubessandra
Copy link

Kubessandra commented May 15, 2020

I think a little update in the readme and this will be good

Copy link

@Kubessandra Kubessandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a section to the Usage example list not only api section.

README.md Outdated
```javascript
async isRewardedVideoPlacementCapped(placementName) {
try {
return await IronSourceRewardedVideo.isRewardedVideoPlacementCapped(placementName);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return await is redundant you can remove the await

Copy link

@Kubessandra Kubessandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More explanation in the Readme

@fearmear
Copy link

Looks great. I going to test it before merging.

Thank you for your contribution!

@Kubessandra
Copy link

Kubessandra commented May 15, 2020

@fearmear Hello, I added a MIT License but this is the name of Redpill can you provide a MIT LICENSE with your name? or with wowmaking, we don't want to become the Owner of this project this is why I'm asking you to change the name in the License, the project need a License or this is illegal to use it.

https://opensource.stackexchange.com/questions/1720/what-can-i-assume-if-a-publicly-published-project-has-no-license

@fearmear
Copy link

Let's leave it as it was provided by the original creator. Please remove the license file from your PR.

@Kubessandra
Copy link

Kubessandra commented May 25, 2020

@fearmear If we let this like that this is illegal to use it.. this is maybe why so many people are not using the package, I will ask the author of the original package

@fearmear
Copy link

fearmear commented Jun 5, 2020

I don't think they will ever reply.
I suggest we ignore the license issue. Obviously they intended to make it MIT that's why package.json has this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants