-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADD METHOD isRewardedVideoPlacementCapped #61
base: master
Are you sure you want to change the base?
Conversation
This reverts commit ef0d4dd.
I think a little update in the readme and this will be good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a section to the Usage example list not only api section.
README.md
Outdated
```javascript | ||
async isRewardedVideoPlacementCapped(placementName) { | ||
try { | ||
return await IronSourceRewardedVideo.isRewardedVideoPlacementCapped(placementName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return await is redundant you can remove the await
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More explanation in the Readme
Looks great. I going to test it before merging. Thank you for your contribution! |
@fearmear Hello, I added a MIT License but this is the name of Redpill can you provide a MIT LICENSE with your name? or with wowmaking, we don't want to become the Owner of this project this is why I'm asking you to change the name in the License, the project need a License or this is illegal to use it. |
Let's leave it as it was provided by the original creator. Please remove the license file from your PR. |
@fearmear If we let this like that this is illegal to use it.. this is maybe why so many people are not using the package, I will ask the author of the original package |
I don't think they will ever reply. |
No description provided.