Ask to save the current layout when closing shuffleboard #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The save dialog pops up for me when I close by clicking on the window close icon (from the OS). But if I select File/Close I don't get the dialog. |
Changes the MainWindowController.close() method to attempt to close the window rather than terminating the program
Codecov Report
@@ Coverage Diff @@
## master #307 +/- ##
============================================
- Coverage 20.85% 20.71% -0.14%
+ Complexity 444 443 -1
============================================
Files 203 203
Lines 5313 5339 +26
Branches 419 420 +1
============================================
- Hits 1108 1106 -2
- Misses 4142 4169 +27
- Partials 63 64 +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #173
This is a "dumb" approach and will always ask for confirmation, even if no changes were made. Making this work appropriately would require some pretty large internal changes to keep track of when user actions are made (tie-in to #138)
Dialog screenshots
Note: the text is subject to change