[TM-1312] users/me #4
Conversation
…e at the controller level as possible.
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 5e23908. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
Sent with 💌 from NxCloud. |
roguenet
force-pushed
the
feat/TM-1312-users-me
branch
from
ca00b34 to
ebef2ad
Compare
roguenet
force-pushed
the
feat/TM-1312-users-me
branch
from
ebef2ad to
b3cfdb2
Compare
roguenet
force-pushed
the
feat/TM-1312-users-me
branch
from
566d3aa to
b31fdbc
Compare
roguenet
force-pushed
the
feat/TM-1312-users-me
branch
from
17f75cc to
d1ca8d5
Compare
|
@Scriptmatico Note that the build is failing right now, but I'm going to address that in the next ticket when I work on getting AWS builds up and running. It's not clear to me at a glance why it's not working on this branch as of the last two commits, but linter and tests are passing, which I think is good enough for this ticket. |
| @@ -0,0 +1,165 @@ | |||
| /* eslint-disable @typescript-eslint/no-explicit-any */ | |||
There was a problem hiding this comment.
I understand now why the rule is being disabled, Im wondering if any of those variables can be properly typed. otherwise it's ok.
There was a problem hiding this comment.
I did spend some time looking into that and didn't find a clean way. I avoid disabling this rule whenever possible.
| @@ -0,0 +1,142 @@ | |||
| /* eslint-disable @typescript-eslint/no-explicit-any */ | |||
There was a problem hiding this comment.
Same comment as before if cant be properly typed is ok for now.
| @@ -0,0 +1,27 @@ | |||
| /* eslint-disable @typescript-eslint/no-explicit-any */ | |||
There was a problem hiding this comment.
I think here message can be typed as string or object.
There was a problem hiding this comment.
Done. Unfortunately, I had to leave the linter rule disabled because of the optionalParams
https://gfw.atlassian.net/browse/TM-1312
FE PR