Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TM-1759] add policy for sitepolygon #72

Open
wants to merge 2 commits into
base: staging
Choose a base branch
from

Conversation

egrojMonroy
Copy link
Collaborator

No description provided.

@egrojMonroy egrojMonroy marked this pull request as ready for review February 28, 2025 21:51
this.builder.can("manage", SitePolygon);
if (this.frameworks.length === 0) {
return;
}
Copy link
Collaborator

@roguenet roguenet Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break the research service account's access. The only permission it has is polygons-manage.

These should be two separate checks:

if (this.permissions.includes("polygons-manage")) {
  this.builder.can("manage", SitePolygon);
}

if (this.frameworks.length > 0) {
  ... put site UUID stuff here.
}

This brings the framework permissions approach in line with other policies, and also removes the need for your PHP PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants