feat(NumberRule): remove space like a thousand delimiter

wrk-flow · Jan 30, 2025 · 6912007 · 6912007
1 parent 00a938f
commit 6912007
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/src/Validation/Rules/NumberRule.php b/src/Validation/Rules/NumberRule.php
@@ -11,6 +11,10 @@ class NumberRule implements Rule
 {
     public function passes($attribute, $value): bool
     {
+        if (is_string($value)) {
+            $value = preg_replace('/\s+/', '', $value);
+        }
+
         if (self::isNumericInt($value)) {
             $intVal = (int) $value;
             return $intVal !== PHP_INT_MAX && $intVal !== PHP_INT_MIN;

diff --git a/tests/Unit/Validation/Rules/NumberRuleTest.php b/tests/Unit/Validation/Rules/NumberRuleTest.php
@@ -19,6 +19,8 @@ protected function testData(): array
         return [
             new RuleExpectation('test', false),
             new RuleExpectation('234', true),
+            new RuleExpectation(" -  1\t234. 065 ", true),
+            new RuleExpectation('  1 234. 065 ', true),
             new RuleExpectation('-234', true),
             new RuleExpectation(234, true),
             new RuleExpectation(-234, true),
@@ -47,6 +49,7 @@ protected function testData(): array
             new RuleExpectation('-,', false),
             new RuleExpectation('.', false),
             new RuleExpectation('', false),
+            new RuleExpectation(null, false),
             new RuleExpectation('9223372036854775807', false),
             new RuleExpectation('9223372036854775807.5', false),
             new RuleExpectation('922337203685477580703434355.5', false),