-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(website): remove chat package and merge #242
base: main
Are you sure you want to change the base?
Conversation
@agentica/benchmark
agentica
@agentica/core
create-agentica
@agentica/pg-vector-selector
@agentica/rpc
commit: |
Signed-off-by: sunrabbit123 <[email protected]>
Signed-off-by: sunrabbit123 <[email protected]>
Signed-off-by: sunrabbit123 <[email protected]>
Signed-off-by: sunrabbit123 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the outdated chat package and related example files, consolidating the implementation into the new website components. Key changes include:
- Removal of all chat examples (shopping and BBS) along with their assets.
- Clean-up of build, configuration, and deployment scripts related to the removed package.
- Elimination of legacy documentation files for the chat package.
Reviewed Changes
Copilot reviewed 50 out of 56 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
packages/chat/src/examples/shopping/script.md | Deleted obsolete shopping chat example script. |
packages/chat/src/examples/shopping/ShoppingChatApplication.tsx | Removed the shopping chat application component. |
packages/chat/src/examples/index.tsx | Removed the index file for chat examples. |
packages/chat/src/examples/bbs/script.md | Deleted obsolete BBS chat example script. |
packages/chat/src/examples/bbs/index.tsx | Removed the BBS chat application entry file. |
packages/chat/src/examples/bbs/IBbsArticle.ts | Removed BBS article interface definitions. |
packages/chat/src/examples/bbs/BbsChatApplication.tsx | Deleted the BBS chat application component. |
packages/chat/src/examples/bbs/BbsArticleService.ts | Removed the service handling BBS articles. |
packages/chat/src/README.md | Removed legacy README for the chat package. |
packages/chat/src/AgenticaChatApplication.tsx | Deleted the Agentica chat application wrapper. |
packages/chat/rollup.config.cjs | Removed build configuration for the chat package. |
packages/chat/eslint.config.mts | Removed ESLint configuration related to the package. |
packages/chat/build/deploy.mjs | Removed deployment script for the chat package. |
packages/chat/README.md | Removed the top-level README for the chat package. |
Files not reviewed (6)
- packages/chat/.gitignore: Language not supported
- packages/chat/LICENSE: Language not supported
- packages/chat/bbs/index.html: Language not supported
- packages/chat/index.html: Language not supported
- packages/chat/package.json: Language not supported
- packages/chat/shopping/index.html: Language not supported
Signed-off-by: sunrabbit123 <[email protected]>
Signed-off-by: sunrabbit123 <[email protected]>
Signed-off-by: sunrabbit123 <[email protected]>
Signed-off-by: sunrabbit123 <[email protected]>
Signed-off-by: sunrabbit123 <[email protected]>
Signed-off-by: sunrabbit123 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for me.
Aside this PR, we need to mark chat library on npm as deprecated.
Waiting for @samchon 's approvement
remine alert |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait until standalone package comes.
ok good, maybe it is my task... sorry We have to go through an eslint github action failure while the project is completed. |
This PR removes the unused chat package and integrates the playground into the website.
After this task, we plan to recreate the standalone project in a modern style. Based on that, the playground and React template will be created.
This pull request introduces several new components and enhancements to the
website/app/_components/playground
directory, specifically focusing on theAgenticaChatMovie
and its associated message and side components. The main changes include new components for handling markdown rendering, chat messages, and chat side movies, along with improvements to the existingPage
component.New Components and Enhancements:
Markdown Rendering:
website/app/_components/playground/markdown/MarkdownViewer.tsx
: Added a newMarkdownViewer
component that usesreact-markdown
along with pluginsrehypeRaw
,rehypeStringify
, andremark-mermaid-plugin
to render markdown content.Chat Movie Components:
website/app/_components/playground/movies/AgenticaChatMovie.tsx
: Introduced theAgenticaChatMovie
component to handle the main chat interface, including state management for chat history, token usage, and user interactions.Chat Message Components:
website/app/_components/playground/movies/messages/AgenticaChatMessageMovie.tsx
: Added a newAgenticaChatMessageMovie
component to render different types of chat messages based on their type (text
,select
,describe
).website/app/_components/playground/movies/messages/AgenticaChatDescribeMessageMovie.tsx
: Introduced theAgenticaChatDescribeMessageMovie
component for rendering messages that describe functions.website/app/_components/playground/movies/messages/AgenticaChatExecuteMessageMovie.tsx
: Added theAgenticaChatExecuteMessageMovie
component to display execution details of functions.website/app/_components/playground/movies/messages/AgenticaChatSelectMessageMovie.tsx
: Created theAgenticaChatSelectMessageMovie
component for rendering function selection messages.website/app/_components/playground/movies/messages/AgenticaChatTextMessageMovie.tsx
: Added theAgenticaChatTextMessageMovie
component to render user and assistant text messages.Chat Side Components:
website/app/_components/playground/movies/sides/AgenticaChatSideMovie.tsx
: Introduced theAgenticaChatSideMovie
component to display agent information, token usage, and function stack.website/app/_components/playground/movies/sides/AgenticaChatFunctionStackSideMovie.tsx
: Added theAgenticaChatFunctionStackSideMovie
component to show a stack of function operations.Page Component Update:
website/app/[[...mdxPath]]/page.jsx
: Modified thePage
component to handle paths that start with "playground" by rendering theMDXContent
directly. (website/app/[[...mdxPath]]/page.jsxL22-R22)