Update Simple Workflow Engine #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SenuDyl
force-pushed
the
simple-workflow-support
branch
from
83f4928 to
ebb6055
Compare
Comment on lines
85
to
106
| org.osgi.framework; version="[1.2.0, 2.0.0)", | ||
| org.osgi.service.component; version="[1.2.0, 2.0.0)", | ||
|
|
||
| org.wso2.carbon.identity.workflow.mgt, | ||
| org.wso2.carbon.identity.workflow.mgt.util, | ||
| org.wso2.carbon.identity.workflow.mgt.bean, | ||
| org.wso2.carbon.identity.workflow.mgt.bean.metadata, | ||
| org.wso2.carbon.identity.workflow.mgt.dto, | ||
| org.wso2.carbon.identity.workflow.mgt.workflow, | ||
| org.wso2.carbon.identity.workflow.mgt.exception, | ||
| org.wso2.carbon.identity.workflow.mgt.dao, | ||
| org.wso2.carbon.identity.role.v2.mgt.core, | ||
| org.wso2.carbon.identity.role.v2.mgt.core.exception, | ||
| org.wso2.carbon.identity.workflow.mgt.callback, | ||
| org.apache.commons.logging, | ||
| org.apache.commons.lang, | ||
| org.wso2.carbon.utils.multitenancy, | ||
| org.wso2.carbon.context, | ||
| org.apache.commons.collections, | ||
| org.wso2.carbon.identity.core.util, | ||
| org.wso2.carbon.database.utils.jdbc, | ||
| org.wso2.carbon.database.utils.jdbc.exceptions |
There was a problem hiding this comment.
Let's follow the same pattern as here (defining the version range)
| String tenantDomain = CarbonContext.getThreadLocalCarbonContext().getTenantDomain(); | ||
| List<String> roleIDList; | ||
| try{ | ||
| roleIDList = WorkflowEngineServiceDataHolder.getInstance().getRoleManagementService().getRoleIdListOfUser(approverId, tenantDomain); |
There was a problem hiding this comment.
Suggested change
| roleIDList = WorkflowEngineServiceDataHolder.getInstance().getRoleManagementService().getRoleIdListOfUser(approverId, tenantDomain); | |
| List<String> roleIDList = WorkflowEngineServiceDataHolder.getInstance().getRoleManagementService().getRoleIdListOfUser(approverId, tenantDomain); |
| throw new WorkflowEngineClientException( | ||
| WorkflowEngineConstants.ErrorMessages.ASSOCIATION_NOT_FOUND.getCode(), | ||
| WorkflowEngineConstants.ErrorMessages.ASSOCIATION_NOT_FOUND.getDescription()); | ||
| // |
There was a problem hiding this comment.
Suggested change
| // |
Comment on lines
68
to
69
|
|
||
|
|
pom.xml
Outdated
| @@ -169,7 +169,12 @@ | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>org.wso2.carbon.identity.framework</groupId> | |||
| <artifactId>org.wso2.carbon.identity.configuration.mgt.core</artifactId> | |||
| <artifactId>org.wso2.carbon.identity.role.v2.mgt.core</artifactId> | |||
| <version>7.7.234-SNAPSHOT</version> | |||
There was a problem hiding this comment.
Suggested change
| <version>7.7.234-SNAPSHOT</version> | |
| <version>7.7.234</version> |
There was a problem hiding this comment.
Let's define the version via a variable.
Ex: ${carbon.identity.framework.version}
We can change the value of that variable.
pom.xml
Outdated
| <dependency> | ||
| <groupId>org.wso2.carbon</groupId> | ||
| <artifactId>org.wso2.carbon.utils</artifactId> | ||
| <version>4.10.34</version> |
SenuDyl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Goals
Approach
User stories
Release note
Documentation
Training
Certification
Marketing
Automation tests
Security checks
Samples
Related PRs
Migrations (if applicable)
Test environment
Learning