-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Arriba (and respective pVACfuse step) to the immuno workflow #115
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Thomas B. Mooney <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me (and familiar, too 🙂) Does the arriba case need the star_fusion_file
input to be supplied? It's one thing that looks different between the two pvacfuse calls, but maybe that's intentional!
@tmooney This was actually something I was wanting to bring up with @malachig and @chrisamiller. Currently pVACfuse ignores a provided star_fusion_file input when it is run with Arriba data because Arriba provides its own Read Support metrics. However, we could potentially still pull Expression metrics from the star_fusion_file. If we allow a star_fusion_file with Arriba, we need to decide which Read Support data takes precedence. |
@tmooney I discussed this with Malachi off-thread and I made a new docker image with added support for arriba with a star fusion file. This PR has been updated to take advantage of this update. |
definitions/tools/arriba.wdl
Outdated
# explicit typing required, don't inline | ||
command <<< | ||
/arriba_v2.4.0/arriba \ | ||
-b /arriba_v2.4.0/database/blacklist_hg38_GRCh38_v2.3.0.tsv.gz \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think all these file names need to be updated to reflect 2.4.0
instead of 2.3.0
. It seems the name of the dir AND the file names change when the db is updated
…on and pass along the Chimeric.out.sam file to Arriba
This is a rebased version of susannasiebert#1