Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue549 - Added the IfcGeometricRepresentationContext "Plan" in the … #468

Conversation

CCT-Mukund-Thakare
Copy link

…filter.

@andyward
Copy link
Member

Thanks for this Mukund! Sorry I was replying with some suggestions on the issue. I'd not add Plan explicitly wrong according to the standards, but I would open up the filter on this fallback code to include any RepresentationContext that supports 3D, for the case where there model if not following the standards.

@CCT-Mukund-Thakare
Copy link
Author

Hello @andyward
I get it, I should not add 'plan' because xbim.geometry.engine is only interested in 3D context type and 'plan' is reserved for 2D.
and we should search for more 3D ContextType rather than 2D ContextTypes in the model.

please check out my this comment as well.
xBimTeam/XbimEssentials#549 (comment)

If this is so can we close this PR ?

@andyward
Copy link
Member

Yes I think the fix is probably wrong. This code is trying to find the most appropriate set of Contexts to use for 3D. Adding in Plan for a specifically wrong model doesn't make sense. Suggest we have another go. Will update on the 549 issue

@andyward andyward closed this Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants