Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get six more pieces of metadata from the YouTube page #46

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

k-k-k-ken
Copy link

Added: description, (date) published, views, thumbnail (url), familyfriendly, and genre.

Added: description, (date) published, views, thumbnail (url), familyfriendly, and genre.
@oalders
Copy link
Collaborator

oalders commented Aug 13, 2018

Thanks! This is looking really good. Let's see what we need to do to wrap this up.

  • You should be able to follow the pattern in t/video_user.t to test the new methods which you have added. There should be at least one test for each new method. Whether you put these all into individual test files or one test file is up to you.
  • We should document these changes in the pod for WWW::YouTube::Download.
  • An appropriate entry should be added to Changes (I'm happy to handle this, if you like.)

Let me know if you run into any problems with the above and thanks for your efforts. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants