CP-54384 Update Auto-Mode Configuration for Pool Operations and Default Values #6484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- For XS8, a configuration file (/etc/xapi.conf.d/ssh-auto-mode.conf) will be loaded, and auto_mode will be set to false. - For XS9, no configuration file exists, so the default value will be set to true. Signed-off-by: Lunfan Zhang[Lunfan.Zhang] <[email protected]>
- Copy auto mode setting from pool coordinator in pool join - Restore auto mode setting to default when pool eject Signed-off-by: Lunfan Zhang[Lunfan.Zhang] <[email protected]>
LunfanZhang
force-pushed
the
private/luzhan/CP-54382
branch
from
695701b to
e114448
Compare
BengangY
reviewed
May 29, 2025
| let ssh_monitor_enabled = | ||
| Fe_systemctl.is_active ~service:!Xapi_globs.ssh_monitor_service | ||
| in | ||
| (* For xs9 when fresh install, the ssh_monitor service is not enabled by default. |
There was a problem hiding this comment.
Why ssh_monitor is not enabled by default on xs9? Do you mean "xs8"?
There was a problem hiding this comment.
The ssh_monitor service should be enabled by default on xs9, so after we set auto_mode to true in db, e still need a mechanism to actually enable the service.
There is some tiny difference between ssh-auto is not enabled by default and ssh_monitor service is not enabled by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aim to add following change for auto-mode:
Copy the auto-mode setting from the pool coordinator during a pool join. and restore the auto-mode setting to default value when a pool eject occurs.
/etc/xapi.conf.d/ssh-auto-mode.conf.