-
Notifications
You must be signed in to change notification settings - Fork 291
CONTRIBUTING: add some initial guidelines #6485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
CONTRIBUTING: add some initial guidelines #6485
Conversation
Can be viewed rendered here: https://github.com/last-genius/xen-api/blob/asv/contribution-guide/CONTRIBUTING.md |
I believe we should manage expectations by saying that commits that break existing (non-public) tests are likely to be reverted. This may sound unfair because tests are not public but I can't see how we can avoid that. The test infrastructure we have in place is almost impossible to make public, independent of any licensing issues. |
What could be made public is the operations / features that are considered essential, and are never to be broken. With this, the existing public tests can be enhanced (unit tests or end-to-end xcp-ng ones) to a point where all the tests that are considered for reverting are public, even if it's replicated inside xenserver's testing suite. |
We might have public tests not in place immediately; I am in favour to add some words about reverting commits and merge this. |
5710c8d
to
20070e4
Compare
Added a quick note:
|
I can't think of anything in particular that the document is missing. I'd like Rob to review it, however |
20070e4
to
5d8cf6f
Compare
Signed-off-by: Andrii Sultanov <[email protected]>
5d8cf6f
to
1c581c0
Compare
Some rough guidelines on the contribution process for the project. Intended more as a starting point for a discussion.