Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add topk #374

Open
wants to merge 41 commits into
base: main
Choose a base branch
from
Open

Add topk #374

wants to merge 41 commits into from
+212 −69

Conversation

dcherian
Copy link
Collaborator

@dcherian dcherian commented Jul 28, 2024 •
edited
Loading

This is pretty ugly:

  1. Doesn't handle topk and nantopk yet
  2. Unlike quantile, topk can work as a tree-reduce algorithm. So we have to hack the k kwarg, passed in finalize_kwargs in many places. This isn't an issue for quantile, because that only works blockwise

pre-commit-ci bot and others added 4 commits July 28, 2024 20:16
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
4b04fde 
for more information, see https://pre-commit.ci
@dcherian
Handle dtypes.NA properly for datetime/timedelta
93800aa
@dcherian
Fix
80c67f4
@dcherian
Merge branch 'main' into topk
7056d18 
* main:
  Fix first, last again (#381)
  Fix docs build (#382)
  Optimize for-loop merging of cohorts. (#378)
  Add cohorts snapshot tests with syrupy (#379)
  Stricter tolerance in property tests (#377)
  Better gridlines
  Update containment image with gridlines, higher dpi
@dcherian dcherian mentioned this pull request Aug 7, 2024
Merged
1 task
dcherian and others added 15 commits January 6, 2025 17:50
@dcherian
Merge branch 'main' into topk
44f5f3f 
* main:
  Revert "Support first, last with datetime, timedelta (#402)" (#404)
  Support first, last with datetime, timedelta (#402)
  Bump codecov/codecov-action from 4.5.0 to 4.6.0 (#401)
  Bump mamba-org/setup-micromamba from 1 to 2 (#400)
  Revert "[revert] test with Xarray PR branch" (#393)
  [pre-commit.ci] pre-commit autoupdate (#399)
  Faster subsetting for cohorts (#397)
  Fix default int on windows, numpy<2 (#395)
  Avoid rechunking when preferred_method="blockwise" (#394)
  Preserve dtype better when specified. (#389)
  Drop python 3.9, use ruff (#392)
  silence warning (#390)
  Expand groupby_reduce property tests (#385)
  Fix bug with NaNs in `by` and method='blockwise' (#384)
  Avoid explicit np.nan, np.inf (#383)
@dcherian
Fixes
c924017
@dcherian
one more fix
7a794ba
@dcherian
fix
eec4dd4
@dcherian
one more fix
6ac9a1f
@dcherian
Fixes.
83594e8
@dcherian
WIP
740f85f
@dcherian
Merge branch 'main' into topk
5d64fd9 
* main:
  Optimize quantile. (#409)
@dcherian
fixes
e177efd
@dcherian
fix
9393470
@dcherian
cleanup
17eb915
@dcherian
works?
dc0df3e
@dcherian
fix quantile
83ae5d8
@dcherian
optimize xrutils.topk
95d20b8
@dcherian
Merge branch 'main' into topk
0b9fafc
dcherian
dcherian commented Jan 8, 2025
View reviewed changes
tests/test_properties.py Outdated Show resolved Hide resolved
@dcherian dcherian closed this Jan 8, 2025
@dcherian dcherian reopened this Jan 8, 2025
@dcherian
generalize new_dims_func
820d46c
@dcherian
Merge branch 'main' into topk
17a4d5d 
* main:
  Bump codecov/codecov-action from 4.6.0 to 5.1.2 (#407)
  [pre-commit.ci] pre-commit autoupdate (#408)
  Back to Xarray release in CI (#414)
  Xfail some cubed tests (#413)
@dcherian
Revert "generalize new_dims_func"
6aa923a 
This reverts commit 820d46c.
@dcherian
Merge branch 'main' into topk
16b0bac 
* main:
  More support for datetime, timedelta (#412)
@dcherian
Support bool
2c6d486
@dcherian
more skipping
0dcd87c
@dcherian dcherian marked this pull request as ready for review January 19, 2025 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dcherian