Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto rechunk to enable blockwise reduction #380

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dcherian
Copy link
Collaborator

@dcherian dcherian commented Aug 2, 2024

Done when

  1. method is None
  2. Grouping and reducing by a 1D array
  3. by is sorted.
  • test for descending too
  • support descending by too

We gate this on fractional change in number of chunks and change in size of largest chunk.

Closes #359

@dcherian dcherian force-pushed the auto-blockwise-rechunk branch 2 times, most recently from 744fda5 to 25e9b4d Compare August 2, 2024 17:11
Done when
1. `method` is None
2. Grouping and reducing by a 1D array

We gate this on fractional change in number of chunks and change in size
of largest chunk.

Closes #359
@dcherian dcherian force-pushed the auto-blockwise-rechunk branch from 25e9b4d to e3b8092 Compare August 2, 2024 17:11
@dcherian dcherian force-pushed the auto-blockwise-rechunk branch from 756c724 to bcae992 Compare August 2, 2024 21:55
@dcherian dcherian force-pushed the auto-blockwise-rechunk branch from bcae992 to 0c0b0e5 Compare August 2, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider preferred_method="blockwise" if by is sorted
1 participant