Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xfail some cubed tests #413

Merged
merged 1 commit into from
Jan 12, 2025
Merged

Xfail some cubed tests #413

merged 1 commit into from
Jan 12, 2025

Conversation

dcherian
Copy link
Collaborator

@tomwhite the latest cubed release seems. to have broken a few things.

@@ -1923,7 +1923,7 @@ def _groupby_combine(a, axis, dummy_axis, dtype, keepdims):
out[field] = combine(a[field], axis=dummy_axis, keepdims=keepdims)
return out

def _groupby_aggregate(a):
def _groupby_aggregate(a, **kwargs):
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now receives dtype

@dcherian dcherian merged commit 29e9d34 into main Jan 12, 2025
15 of 16 checks passed
@dcherian dcherian deleted the cubed-xfail branch January 12, 2025 23:20
@tomwhite
Copy link
Contributor

Thanks @dcherian - I'll see if I can fix this.

dcherian added a commit that referenced this pull request Jan 13, 2025
* main:
  Bump codecov/codecov-action from 4.6.0 to 5.1.2 (#407)
  [pre-commit.ci] pre-commit autoupdate (#408)
  Back to Xarray release in CI (#414)
  Xfail some cubed tests (#413)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants