-
Notifications
You must be signed in to change notification settings - Fork 0
Add precommit #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add precommit #10
Conversation
enabling pyright seems to create a lot of issues that are quite hard to trace. I am not certain whether these checks actually have been ran with the intent of fixing in the original repository. A lot of the issues are due to the use of @thewtex any thoughts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💖
Use of pre-commit is a wonderful step forward. If pyright is too big of a jump now, an issue could be created and the current progress merged. |
We can also enable the pre-commit bot which i find is a pretty nice UI for the pre-commit errors keeping them visually separate from the tests and it will auto push fixes which can be a ncie help to new contributors who don't want to set up pre-commit |
I think I just have enabled it now. |
in it goes. |
closes #6
Draft PR replacing current linters, typecheckers and formattters with pre-commit and fixing outstanding issues related to those. Also add pre-commit github workflow.
cc @ianhi