Skip to content

Add precommit #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 28, 2025
Merged

Add precommit #10

merged 11 commits into from
Jul 28, 2025

Conversation

melonora
Copy link
Contributor

@melonora melonora commented Jul 26, 2025

closes #6

Draft PR replacing current linters, typecheckers and formattters with pre-commit and fixing outstanding issues related to those. Also add pre-commit github workflow.

cc @ianhi

@melonora
Copy link
Contributor Author

melonora commented Jul 26, 2025

enabling pyright seems to create a lot of issues that are quite hard to trace. I am not certain whether these checks actually have been ran with the intent of fixing in the original repository. A lot of the issues are due to the use of overload creating difficulties for pyright.

@thewtex any thoughts?

Copy link
Contributor

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💖

@thewtex
Copy link
Contributor

thewtex commented Jul 28, 2025

Use of pre-commit is a wonderful step forward. If pyright is too big of a jump now, an issue could be created and the current progress merged.

@ianhi
Copy link

ianhi commented Jul 28, 2025

We can also enable the pre-commit bot which i find is a pretty nice UI for the pre-commit errors keeping them visually separate from the tests and it will auto push fixes which can be a ncie help to new contributors who don't want to set up pre-commit

@melonora
Copy link
Contributor Author

We can also enable the pre-commit bot which i find is a pretty nice UI for the pre-commit errors keeping them visually separate from the tests and it will auto push fixes which can be a ncie help to new contributors who don't want to set up pre-commit

I think I just have enabled it now.

@melonora
Copy link
Contributor Author

in it goes.

@melonora melonora merged commit bd71550 into main Jul 28, 2025
6 checks passed
@melonora melonora mentioned this pull request Jul 28, 2025
@melonora melonora deleted the add_precommit branch July 28, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use pre-commit and add workflow
3 participants