Improvement: Update progress and recording indicators for Live TV and Radio #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the indicators for progress and recording to a progress bar. The progress bar is located on the left side, uses dark gray background and Kodi blue for the progress. Total runtime is located right aligned and under the bar. The recording indicator is located in a reserved area left of the runtime. In the EPG the highlighting is done by changing the cell background and letting the start time label use a bigger font size and label color.
wutschel
force-pushed
the
improve_livetv
branch
from
fa7b7a1 to
4481374
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR modernizes the way of visualizing a broadcast's progress and recording state. The current pie chart and its runtime label are hard to read. The recording icon shown in the middle of the pie chart is not recognizable well in channel list view. To improve this, a new class
ProgressBarViewis introduced, the formerly usedProgressPieViewis removed.Horizontal Progress Bar
The new visualization uses a horizontal progress bar, which is placed on the left side and uses the same width as the thumbnail or label under which it is placed. The progress bar has a dark gray background and uses Kodi blue to show the progress.
Runtime and Recording State
Total runtime is located right aligned under the progress bar. The recording indicator is located in a reserved area left of the runtime.
EPG
In the EPG the highlighting of the current active broadcast is done by changing the cell background and letting the start time label use a bigger font size and label color.
Impression
Screenshots (left pair = new, right pair = old):
https://ibb.co/zmXZ1FY
Summary for release notes
Improvement: Update progress and recording indicators for Live TV and Radio