Add command to generate cryptosign challenge #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muzzammilshahid
force-pushed
the
generate-cryptosign-challenge
branch
5 times, most recently
from
ad41d82 to
550c8a1
Compare
om26er
reviewed
Jun 3, 2024
cmd/wampproto/helpers.go
Outdated
| @@ -0,0 +1,16 @@ | |||
| package main | |||
There was a problem hiding this comment.
should be moved out of the cmd package to the root of this repository. Create helpers.go at the root of the project
muzzammilshahid
force-pushed
the
generate-cryptosign-challenge
branch
from
550c8a1 to
8414184
Compare
muzzammilshahid
force-pushed
the
generate-cryptosign-challenge
branch
from
8414184 to
acc5548
Compare
om26er
reviewed
Jun 4, 2024
helpers.go
Outdated
| @@ -0,0 +1,16 @@ | |||
| package wampproto_cli | |||
There was a problem hiding this comment.
Suggested change
| package wampproto_cli | |
| package wampprotocli |
om26er
reviewed
Jun 4, 2024
helpers.go
Outdated
| "encoding/hex" | ||
| ) | ||
|
|
||
| func HexToBase64String(hexStr string) (string, error) { |
There was a problem hiding this comment.
Suggested change
| func HexToBase64String(hexStr string) (string, error) { | |
| func HexToBase64(hexStr string) (string, error) { |
om26er
reviewed
Jun 4, 2024
helpers_test.go
Outdated
|
|
||
| "github.com/stretchr/testify/require" | ||
|
|
||
| main "github.com/xconnio/wampproto-cli" |
There was a problem hiding this comment.
Suggested change
| main "github.com/xconnio/wampproto-cli" | |
| main "github.com/xconnio/wampproto-cli" |
use the package name, not main
om26er
reviewed
Jun 4, 2024
cmd/wampproto/main.go
Outdated
| hello := messages.NewHello("realm1", "test", nil, nil, []string{"anonymous"}) | ||
| serializer := &serializers.MsgPackSerializer{} | ||
| data, err := serializer.Serialize(hello) | ||
| const versionString = "0.1.0" |
There was a problem hiding this comment.
move inside the below const stanza
om26er
reviewed
Jun 4, 2024
cmd/wampproto/main.go
Outdated
| return c, nil | ||
| } | ||
|
|
||
| func Run(args []string) error { |
There was a problem hiding this comment.
Suggested change
| func Run(args []string) error { | |
| func Run(args []string) error { |
This function may just return the output string and the error. Then it becomes super easy to work in tests as well. No hacks needed to check shell output
muzzammilshahid
force-pushed
the
generate-cryptosign-challenge
branch
from
acc5548 to
6ef4708
Compare
muzzammilshahid
force-pushed
the
generate-cryptosign-challenge
branch
from
6ef4708 to
9aeae3b
Compare
om26er
reviewed
Jun 4, 2024
| main "github.com/xconnio/wampproto-cli/cmd/wampproto" | ||
| ) | ||
|
|
||
| func TestRunGenerateChallenge(t *testing.T) { |
There was a problem hiding this comment.
These tests can be simplified, no need to loop, no need to check regex. If the output is supposed to be hex, just decode and if it works its correct. Same for base64.
om26er
reviewed
Jun 4, 2024
helpers_test.go
Outdated
| } | ||
|
|
||
| // test invalid HexStrings | ||
| for _, rawStr := range []string{ |
There was a problem hiding this comment.
use t.Run() and make them named tests within.
muzzammilshahid
force-pushed
the
generate-cryptosign-challenge
branch
4 times, most recently
from
cf8930a to
2a5bd90
Compare
muzzammilshahid
force-pushed
the
generate-cryptosign-challenge
branch
from
2a5bd90 to
b9e9b9e
Compare
om26er
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.