Update libbpf to 0.0.8 release #126
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting from 0.0.7 libbpf requires zlib as a build dependency. This commit adds -lz to LIBS in common.mk and adds zlib-devel as a libbpf build dependency in the ansible playbook. Signed-off-by: Zebaz <[email protected]>
|
Thank you for the pull request! I'd like to hold off on merging it until I've had a chance to go over the whole tutorial for any updates; is there any urgent reason you need this updated now? |
|
No urgency whatsoever, I was doing some experimenting with bpf helpers introduced in newer versions of libbpf and noticed that the repository missed zlib dependency to work with this version. Just thought I’d push my fixes upstream. Fully understandable you’d want to go over the examples, thanks for your quick reply! |
|
Cool, just checking. Thanks for the PR in any case; I really should get
around to taking a look at this soon :)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update libbpf and pin to specific release (0.0.8).
Starting from 0.0.7 libbpf requires zlib as a build dependency.
This PR adds -lz to LIBS in common.mk and adds zlib-devel as a libbpf build dependency in the ansible playbook.