testing: don't cd to git root dir in lit #3953
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superlopuh
requested review from
compor,
alexarice,
math-fehr,
PapyChacal,
qaco,
jorendumoulin and
webmiche
superlopuh
commented
Feb 24, 2025
superlopuh
commented
Feb 24, 2025
| @@ -19,7 +21,9 @@ | |||
| ctx.register_dialect(n, f) | |||
|
|
|||
| # Open the IRDL description of cmath, parse it | |||
| f = open("tests/filecheck/dialects/irdl/cmath.irdl.mlir") | |||
|
|
|||
| file_path = Path(__file__).parent / "cmath.irdl.mlir" | |||
There was a problem hiding this comment.
a bit more resilient to where this is called from, just do relative paths
alexarice
approved these changes
Feb 24, 2025
|
I'm a bit stumped by this, it looks like |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change in configuration was motivated by the lack of detection of missing
__init__.pyfiles in the project. We now have a ruff check for this (#3945), but in my changing the config, I found a number of other issues stemming from thecd ../..in the preamble to the tests. One is that for some reason files with no RUN lines aren't detected with the preamble. I fixed the broken tests that weren't run in a separate PR (#3944), so this is just about making the config change and making minor fixes to remaining files.