core: Make IRDLOperation results typed #3991
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now, defining a result with `resname = result_def(T)` will make `resname` have the type `SSAValue[T]`. This removes a lot of `cast` and `isa`/`isattr` in our codebase stack-info: PR: #3991, branch: math-fehr/stack/6
math-fehr
added a commit
that referenced
this pull request
Feb 28, 2025
Now, defining a result with `resname = result_def(T)` will make `resname` have the type `SSAValue[T]`. This removes a lot of `cast` and `isa`/`isattr` in our codebase stack-info: PR: #3991, branch: math-fehr/stack/6
math-fehr
force-pushed
the
math-fehr/stack/6
branch
from
ba07176 to
5d1bfda
Compare
math-fehr
force-pushed
the
math-fehr/stack/5
branch
from
d463989 to
1be5202
Compare
This was referenced Feb 28, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## math-fehr/stack/5 #3991 +/- ##
=====================================================
+ Coverage 90.19% 90.22% +0.02%
=====================================================
Files 458 458
Lines 58317 58291 -26
Branches 5694 5685 -9
=====================================================
- Hits 52600 52593 -7
+ Misses 4322 4313 -9
+ Partials 1395 1385 -10 ☔ View full report in Codecov by Sentry. |
math-fehr
force-pushed
the
math-fehr/stack/5
branch
from
1be5202 to
93f5abe
Compare
math-fehr
force-pushed
the
math-fehr/stack/6
branch
from
5d1bfda to
4d4bb1e
Compare
math-fehr
added a commit
that referenced
this pull request
Feb 28, 2025
Now, defining a result with `resname = result_def(T)` will make `resname` have the type `SSAValue[T]`. This removes a lot of `cast` and `isa`/`isattr` in our codebase stack-info: PR: #3991, branch: math-fehr/stack/6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
core: Make IRDLOperation results typed
Now, defining a result with
resname = result_def(T)will makeresnamehave the typeSSAValue[T].This removes a lot of
castandisa/isattrin our codebase