Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALFREDOPS-864: fix broken integration tests #65

Merged
merged 4 commits into from
Jan 9, 2025

Conversation

pvriel
Copy link
Contributor

@pvriel pvriel commented Jan 8, 2025

https://xenitsupport.jira.com/browse/ALFREDOPS-864

Similar to the problem we had with #59, the web scripts from the integration tests need to be moved to the main application context.

One problem I had while working on this PR was that the web scripts from the integration tests are referring to beans from the health processor application context. While Alfresco provides the SubsystemProxyFactory class to circumvent this problem, this only works if you are working with interfaces to work with the proxied beans, which was not possible here. Therefore, the class hierarchy has been slightly altered:

original:

classDiagram
    HealthFixerPlugin <-- ToggleableHealthFixerPlugin
    ToggleableHealthFixerPlugin <|-- AbstractSolrNodeFixerPlugin
    AbstractSolrNodeFixerPlugin <|-- SolrMissingNodeFixerPlugin
    AbstractSolrNodeFixerPlugin <|-- SolrDuplicateNodeFixerPlugin
Loading

new one:

classDiagram
    HealthFixerPlugin <-- ToggleableHealthFixerPlugin
    ToggleableHealthFixerPlugin <-- SolrMissingNodeFixerPlugin
    ToggleableHealthFixerPlugin <-- SolrDuplicateNodeFixerPlugin

    ToggleableHealthFixerPlugin <-- AbstractSolrNodeFixerPluginImpl
        AbstractSolrNodeFixerPluginImpl <|-- SolrDuplicateNodeFixerPluginImpl
    SolrDuplicateNodeFixerPlugin <-- SolrDuplicateNodeFixerPluginImpl
    AbstractSolrNodeFixerPluginImpl <|-- SolrMissingNodeFixerPluginImpl
    SolrMissingNodeFixerPlugin <-- SolrMissingNodeFixerPluginImpl
Loading

@pvriel pvriel force-pushed the ALFREDOPS-864-fix-broken-integration-tests branch from 719ae10 to b5b198e Compare January 8, 2025 14:26
@pvriel pvriel merged commit 3dd8d5d into master Jan 9, 2025
11 checks passed
@pvriel pvriel deleted the ALFREDOPS-864-fix-broken-integration-tests branch January 9, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants