Add HAL-FORMS encoders for uri-list, form-data & x-www-form-urlencoded #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The JSON encoder can't handle file uploads; instead of creating a clobbered JSON object (or omitting the field) if there is a file field present, immediately fail when selecting the encoder.
An encoder can be registered for multiple content types; ensure that the content-type that was actually set on the HAL-FORMS template is sent in the request.
Adding a shortcut method to retrieve an object containing propertyName->value mappings directly
Instead of needing use HalFormValues#values to retrieve an object suitable for encoding, accept the HalFormValues directly. For convenience (at the cost of some type-checking), it's also allowed to pass the values as a HalFormValuesMap object directly
For HAL-FORMS templates with method set to GET (or HEAD); we can't send any body, but need to send the request as query parameters instead. We can only encode to the application/x-www-form-urlencoded content type like this, because a query string is actually that encoding; but in the URL instead of inside the request body.
vierbergenlars
force-pushed
the
more-encoders
branch
from
b0174f2 to
751e950
Compare
rschev
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most encoders do not actually support encoding files; so instead of creating a broken JSON object or omitting the field, immediately fail while selecting the encoder, so failure is not dependent on the user-entered data
HalFormValues#valueMap: A shortcut to retrieve an object simply mapping propertyName to the value directlyHalFormsCodec#encode()easier by allowingHalFormValuesor its valueMap being passed.