Initial commit for the fetch-hooks package #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vierbergenlars
force-pushed
the
init-fetch-hooks
branch
from
6be5ff0 to
dd2c010
Compare
|
tgeens
reviewed
Apr 2, 2024
| * Hook function that can be applied on `fetch()` to return a new, hooked `fetch()` function | ||
| */ | ||
| export interface FetchHook { | ||
| (fetch: Fetch | HookedFetch): HookedFetch; |
There was a problem hiding this comment.
Interface has only a call signature, you should use a function type instead.
There was a problem hiding this comment.
When we need to extend hooks, more attributes will be added to the interface, so I would prefer to keep it in this format.
tgeens
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fetch-hooks allows inserting hooks around the
fetch()function.This allows composing functionality with small hook functions instead of having one large data fetching function laying around in the codebase where all common functionality is applied