FEATURE: add entity to snap pick result #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xeolabs
added a commit
that referenced
this pull request
Nov 23, 2023
xeolabs
added a commit
that referenced
this pull request
Nov 23, 2023
Make snap pick result return snapped Entity, not Mesh #1248
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
snappedEntity&entityto thescene.snapPick()result.Use case:
While snap picking with a custom measurement plugin, it may be interesting to link the snap pick (surface/edge/vertex) to an entity to hide/show the corresponding measure when the entity is hidden/shown.
To go further:
The PR closes a little bit more the differences between the standard
scene.pickand the snap pickscene.snapPick. Maybe later, both can be merged into one with sone parameters to allow both behaviours on the same API.