[BREAKING] Modify WebIFCLoaderPlugin to expect externally-provided web-ifc API #1401
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the bundled web-ifc API implementation from xeokit-sdk, so that
WebIFCLoaderPlugin
now expects the user to instantiate that API themselves externally and inject it into theWebIFCLoaderPlugin
constructor.Previously, the
web-ifc
API was instantiated and managed internally withinWebIFCLoaderPlugin
. This meant that we needed to bundle the API within thexeokit-sdk
library, which had the disadvantage of increasing the size of thexeokit-sdk
, as well as coupling it to a specific version ofweb-ifc
.After this PR, users must instantiate and initialize the
web-ifc
API themselves, then inject it into theWebIFCLoaderPlugin
constructor, as shown in the code snippet below.This is a breaking change in
xeokit-sdk
for users of ourWebIFCLoaderPlugin
, but is not a breaking change forxeokit-bim-viewer
, which does not useWebIFCLoaderPlugin
.)