Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1631] fire events when position/scale/rotation are set #1633

Closed
wants to merge 1 commit into from
Closed

[#1631] fire events when position/scale/rotation are set #1633

wants to merge 1 commit into from

Conversation

hamza-hajji
Copy link
Contributor

PR for #1631

@xeolabs
Copy link
Member

xeolabs commented Aug 16, 2024

Thanks!
Have you signed our contributor's agreement yet?

@hamza-hajji
Copy link
Contributor Author

hamza-hajji commented Aug 16, 2024 •
edited
Loading

@xeolabs I didn't, I'm not sure what it is exactly, can I not contribute without signing it?

@xeolabs
Copy link
Member

xeolabs commented Aug 16, 2024 •
edited
Loading

@xeolabs I didn't, I'm not sure what it is exactly, can I not contribute without signing it?

Gotcha - yeah because this repo is used by our partners, we need contributors to sign the CAG - here's the details: https://github.com/xeokit/xeokit-sdk/blob/master/CONTRIBUTING.md#pull-requests

Please send to [email protected]

@xeolabs xeolabs closed this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hamza-hajji @xeolabs